Postgres Pro
Downloads
Home   >   mailing lists

Re: On login trigger: take three - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: On login trigger: take three
Date
Msg-id ZSyLN2HTz_iLSKkH@paquier.xyz
Whole thread Raw
In response to Re: On login trigger: take three  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: On login trigger: take three  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, Oct 16, 2023 at 02:47:03AM +0300, Alexander Korotkov wrote:
> The attached revision fixes test failures spotted by
> commitfest.cputube.org.  Also, perl scripts passed perltidy.

Still you've missed a few things.  At quick glance:
- The code indentation was off a bit in event_trigger.c.
- 005_login_trigger.pl fails if the code is compiled with
ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS because a WARNING is
reported in test "create tmp objects: err equals".
- 005_sspi.pl is older than the new test 005_login_trigger.pl, could
you rename it with a different number?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: run pgindent on a regular basis / scripted manner
Next
From: Richard Guo
Date:
Subject: Re: Check each of base restriction clauses for constant-FALSE-or-NULL