Re: [PATCH] Add min/max aggregate functions to BYTEA - Mailing list pgsql-hackers

From Marat Bukharov
Subject Re: [PATCH] Add min/max aggregate functions to BYTEA
Date
Msg-id CAPCEVGVi5A65V5chbdwyh9jtsFWuz1eUR__mkPbkHL3MJtpTzA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add min/max aggregate functions to BYTEA  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: [PATCH] Add min/max aggregate functions to BYTEA
List pgsql-hackers
V5 patch. I've added more tests with different bytea sizes

--

With best regards,
Marat Bukharov

чт, 4 июл. 2024 г. в 15:29, Aleksander Alekseev <aleksander@timescale.com>:
>
> Hi Marat,
>
> > V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP
>
> Thanks for the patch.
>
> Please add it to the nearest open commitfest [1].
>
> ```
> +select min(v) from bytea_test_table;
> + min
> +------
> + \xaa
> +(1 row)
> +
> +select max(v) from bytea_test_table;
> + max
> +------
> + \xff
> +(1 row)
> ```
>
> If I understand correctly, all the v's are of the same size. If this
> is the case you should add more test cases.
>
> [1]: https://commitfest.postgresql.org/
>
> --
> Best regards,
> Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: Convert sepgsql tests to TAP
Next
From: Marat Bukharov
Date:
Subject: Re: [PATCH] Add min/max aggregate functions to BYTEA