Re: [PATCH] Add min/max aggregate functions to BYTEA - Mailing list pgsql-hackers

From Andrey M. Borodin
Subject Re: [PATCH] Add min/max aggregate functions to BYTEA
Date
Msg-id 0B14B264-B120-454F-8F6E-BF36B23DC5A2@yandex-team.ru
Whole thread Raw
In response to Re: [PATCH] Add min/max aggregate functions to BYTEA  (Marat Bukharov <marat.buharov@gmail.com>)
List pgsql-hackers

> On 24 Jul 2024, at 17:42, Marat Bukharov <marat.buharov@gmail.com> wrote:
>
> V5 patch. I've added more tests with different bytea sizes

Hi Marat!

This looks like a nice feature to have.

I’ve took a look into the patch and have few suggestions:
0. Please write more descriptive commit message akin to [0]
1. Use oids from development range 8000-9999
2. Replace VARDATA_ANY\memcmp dance with a call to varstrfastcmp_c().

Thank you!


Best regards, Andrey Borodin.

[0] https://github.com/postgres/postgres/commit/a0f1fce80c03


pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Logical Replication of sequences
Next
From: Ashutosh Bapat
Date:
Subject: Re: Small refactoring around vacuum_open_relation