Re: [PATCH] Add min/max aggregate functions to BYTEA - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Add min/max aggregate functions to BYTEA
Date
Msg-id CAJ7c6TMLcsisvnCLDyfhcbeVvJeNQABM12+gYjqh4m6cKinN+A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add min/max aggregate functions to BYTEA  (Marat Bukharov <marat.buharov@gmail.com>)
Responses Re: [PATCH] Add min/max aggregate functions to BYTEA
Re: [PATCH] Add min/max aggregate functions to BYTEA
List pgsql-hackers
Hi Marat,

> V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP

Thanks for the patch.

Please add it to the nearest open commitfest [1].

```
+select min(v) from bytea_test_table;
+ min
+------
+ \xaa
+(1 row)
+
+select max(v) from bytea_test_table;
+ max
+------
+ \xff
+(1 row)
```

If I understand correctly, all the v's are of the same size. If this
is the case you should add more test cases.

[1]: https://commitfest.postgresql.org/

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Jelte Fennema-Nio
Date:
Subject: Re: Make query cancellation keys longer
Next
From: Erik Wienhold
Date:
Subject: Re: Underscore in positional parameters?