Re: Fwd: Discussion - Search Objects - Mailing list pgadmin-hackers

From Jasmin Dizdarevic
Subject Re: Fwd: Discussion - Search Objects
Date
Msg-id CAOveQuNsoAZLBau4XWex-6MeYE-+fR25xqqY+u5GyadP8NC0rA@mail.gmail.com
Whole thread Raw
In response to Re: Fwd: Discussion - Search Objects  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Fwd: Discussion - Search Objects  (Guillaume Lelarge <guillaume@lelarge.info>)
List pgadmin-hackers


2011/7/4 Guillaume Lelarge <guillaume@lelarge.info>
On Mon, 2011-07-04 at 09:10 +0200, Guillaume Lelarge wrote:
> On Sun, 2011-07-03 at 23:39 +0200, Jasmin Dizdarevic wrote:
> > Could somebody review the patch and maybe commit it?
> >
>
> I'll look into it tonight, unless someone beats me to it.
>

Thank's for checking.
 
Seems mostly good to me, but I have too questions:

 * why do you use twice the Trim command in
  "browser->GetItemText(parent).BeforeFirst('(').Trim().Trim(false)"?

I've misunderstood the wx-docs. 
 
 * why is the search object menu only available to non maintenance DB?
(((pgDatabase *)obj)->GetName() != ((pgDatabase
*)obj)->GetServer()->GetDatabaseName())

copy-paste mistake

patch attached.
 

Attachment

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: Fwd: Discussion - Search Objects
Next
From: Thom Brown
Date:
Subject: [FEATURE] Add schema option to all relevant objects