Re: Fwd: Discussion - Search Objects - Mailing list pgadmin-hackers

On Mon, 2011-07-04 at 09:10 +0200, Guillaume Lelarge wrote:
> On Sun, 2011-07-03 at 23:39 +0200, Jasmin Dizdarevic wrote:
> > Could somebody review the patch and maybe commit it?
> >
>
> I'll look into it tonight, unless someone beats me to it.
>

Seems mostly good to me, but I have too questions:

 * why do you use twice the Trim command in
   "browser->GetItemText(parent).BeforeFirst('(').Trim().Trim(false)"?

 * why is the search object menu only available to non maintenance DB?
(((pgDatabase *)obj)->GetName() != ((pgDatabase
*)obj)->GetServer()->GetDatabaseName())


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com