Re: Fwd: Discussion - Search Objects - Mailing list pgadmin-hackers

On Mon, 2011-07-04 at 23:42 +0200, Jasmin Dizdarevic wrote:
>
>
> 2011/7/4 Guillaume Lelarge <guillaume@lelarge.info>
>         On Mon, 2011-07-04 at 09:10 +0200, Guillaume Lelarge wrote:
>         > On Sun, 2011-07-03 at 23:39 +0200, Jasmin Dizdarevic wrote:
>         > > Could somebody review the patch and maybe commit it?
>         > >
>         >
>         > I'll look into it tonight, unless someone beats me to it.
>         >
>
>
> Thank's for checking.
>
>
>         Seems mostly good to me, but I have too questions:
>
>          * why do you use twice the Trim command in
>
>         "browser->GetItemText(parent).BeforeFirst('(').Trim().Trim(false)"?
>
>
> I've misunderstood the wx-docs.
>
>          * why is the search object menu only available to non
>         maintenance DB?
>         (((pgDatabase *)obj)->GetName() != ((pgDatabase
>         *)obj)->GetServer()->GetDatabaseName())
>
>
>
> copy-paste mistake
>
>
> patch attached.
>

OK, I'm still working on it. I need the search.png image, can you send
it to me? as I can't apply the patch, I can't extract the image. Thanks.


--
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com