On Thu, Jun 27, 2019 at 8:14 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> Hi, thanks for the patch.
Thanks for looking at it!
> On 2019-Jun-27, Julien Rouhaud wrote:
>
> > I just realized that 7e534adcdc7 broke support for hypothetical
> > indexes using BRIN am. Attached patch fix the issue.
> >
> > There's no interface to provide the hypothetical pagesPerRange value,
> > so I used the default one, and used simple estimates.
>
> I think it would look nicer to have a routine parallel to brinGetStats()
> (brinGetStatsHypothetical?), instead of polluting selfuncs.c with these
> gory details.
I'm not opposed to it, but I used the same approach as a similar fix
for gincostestimate() (see 7fb008c5ee5). If we add an hypothetical
version of brinGetStats(), we should also do it for ginGetStats().
> This seems back-patchable ...
I definitely hope so!
