Re: Hypothetical indexes using BRIN broken since pg10 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Hypothetical indexes using BRIN broken since pg10
Date
Msg-id 20190627184601.GA32018@alvherre.pgsql
Whole thread Raw
In response to Re: Hypothetical indexes using BRIN broken since pg10  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: Hypothetical indexes using BRIN broken since pg10
List pgsql-hackers
On 2019-Jun-27, Julien Rouhaud wrote:

> On Thu, Jun 27, 2019 at 8:14 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> > I think it would look nicer to have a routine parallel to brinGetStats()
> > (brinGetStatsHypothetical?), instead of polluting selfuncs.c with these
> > gory details.
> 
> I'm not opposed to it, but I used the same approach as a similar fix
> for gincostestimate() (see 7fb008c5ee5).

How many #define lines did you have to add to selfuncs there?

> If we add an hypothetical
> version of brinGetStats(), we should also do it for ginGetStats().

Dunno, seems pointless.  The GIN case is different.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Dave Cramer
Date:
Subject: Re: Fix doc bug in logical replication.
Next
From: Erik Nordström
Date:
Subject: Missing hook for UPPERREL_PARTIAL_GROUP_AGG rels?