Re: Hypothetical indexes using BRIN broken since pg10 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Hypothetical indexes using BRIN broken since pg10
Date
Msg-id 20190627181447.GA30619@alvherre.pgsql
Whole thread Raw
In response to Hypothetical indexes using BRIN broken since pg10  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: Hypothetical indexes using BRIN broken since pg10
List pgsql-hackers
Hi, thanks for the patch.

On 2019-Jun-27, Julien Rouhaud wrote:

> I just realized that 7e534adcdc7 broke support for hypothetical
> indexes using BRIN am.  Attached patch fix the issue.
> 
> There's no interface to provide the hypothetical pagesPerRange value,
> so I used the default one, and used simple estimates.

I think it would look nicer to have a routine parallel to brinGetStats()
(brinGetStatsHypothetical?), instead of polluting selfuncs.c with these
gory details.

This seems back-patchable ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs
Next
From: Tomas Vondra
Date:
Subject: Re: Fix doc bug in logical replication.