Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explainplan as JPEG/SVG format - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explainplan as JPEG/SVG format
Date
Msg-id CANxoLDfaasCdWRYfCo_njnt+8DXSjy4+U_zfDyaWhi4k6hcFFw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explain plan as JPEG/SVG format  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explainplan as JPEG/SVG format  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi Hackers

I didn't find the solution to show embedded SVG in Internet Explorer, so I have disabled the "Download" button for Internet Explorer. Added new function to get the browser name and version.

Attached is the modified patch, please review it. 

On Mon, Dec 3, 2018 at 6:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers, 

I am currently working on Feature 3589 "Allow user to save/download Explain plan as JPEG/SVG format."  I have added one download button to the toolbar in "Explain" tab, when clicked it will download the explain plan as a SVG file.

To add this feature I'll have to modify the logic, so instead of providing relative path of each plan (svg image), I have embedded the binary data which is required to download the Explain plan.

I have tested it on following:
Attached is the working patch for the above except Internet Explorer. I have tried a lot to figure out the solution, but unable to fix the issue. Need help/suggestions how to fix the issue on Internet Explorer. 

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: Build failed in Jenkins: pgadmin4-master-python27 #825
Next
From: Akshay Joshi
Date:
Subject: [pgAdmin4][Patch]: RM #3798 Unable to launch query tool window through Browser if user select any language except English under preferences section