Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explainplan as JPEG/SVG format - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explainplan as JPEG/SVG format
Date
Msg-id CA+OCxozxvgwQT__yCkRir8fJdX=oxyNvXYNBkohGy=onefzW5g@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explainplan as JPEG/SVG format  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explainplan as JPEG/SVG format  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

On Thu, Dec 6, 2018 at 6:51 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers

I didn't find the solution to show embedded SVG in Internet Explorer, so I have disabled the "Download" button for Internet Explorer. Added new function to get the browser name and version.

Attached is the modified patch, please review it. 

Looking good. A few thoughts though:

- Can we add tests? I'm not sure if it's feasible to just save a plan and then check the contents look sane though, due to the download dialogue.

- The plan isn't overly helpful without the stats. Can you think of any way we can include them - e.g. is it possible to do mouseovers in pure SVG? Or perhaps we need to render a number of tables below the diagram?
 

On Mon, Dec 3, 2018 at 6:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers, 

I am currently working on Feature 3589 "Allow user to save/download Explain plan as JPEG/SVG format."  I have added one download button to the toolbar in "Explain" tab, when clicked it will download the explain plan as a SVG file.

To add this feature I'll have to modify the logic, so instead of providing relative path of each plan (svg image), I have embedded the binary data which is required to download the Explain plan.

I have tested it on following:
Attached is the working patch for the above except Internet Explorer. I have tried a lot to figure out the solution, but unable to fix the issue. Need help/suggestions how to fix the issue on Internet Explorer. 

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgAdmin4][Patch]: RM #3798 Unable to launch query tool window through Browser if user select any language except English under preferences section
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Ensure the browser toolbar buttons work inlanguages