I didn't find the solution to show embedded SVG in Internet Explorer, so I have disabled the "Download" button for Internet Explorer. Added new function to get the browser name and version.
Attached is the modified patch, please review it.
Looking good. A few thoughts though:
- Can we add tests? I'm not sure if it's feasible to just save a plan and then check the contents look sane though, due to the download dialogue.
You are talking about feature tests. If yes then it's been difficult because each browser have different download dialog.
- The plan isn't overly helpful without the stats. Can you think of any way we can include them - e.g. is it possible to do mouseovers in pure SVG? Or perhaps we need to render a number of tables below the diagram?
I'll try to include tooltips on mouseover in pure SVG.
I am currently working on Feature 3589 "Allow user to save/download Explain plan as JPEG/SVG format." I have added one download button to the toolbar in "Explain" tab, when clicked it will download the explain plan as a SVG file.
To add this feature I'll have to modify the logic, so instead of providing relative path of each plan (svg image), I have embedded the binary data which is required to download the Explain plan.
Internet Explorer (Images are not rendered, shown X icon.). Please refer attached image.
Attached is the working patch for the above except Internet Explorer. I have tried a lot to figure out the solution, but unable to fix the issue. Need help/suggestions how to fix the issue on Internet Explorer.