Re: [HACKERS] the need to finish - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: [HACKERS] the need to finish
Date
Msg-id CANP8+jJ19_iPup9do8PMvgKE-MnoGmiH+=u52F4TbiSMzomAyQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] the need to finish  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] the need to finish  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 12 April 2017 at 16:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Erik Rijkers <er@xs4all.nl> writes:
>> Logical replication emits logmessages like these:
>> DETAIL:  90 transactions need to finish.
>> DETAIL:  87 transactions need to finish.
>> DETAIL:  70 transactions need to finish.
>
>> Could we get rid of that 'need'?   It strikes me as a bit off; something
>> that people would say but not a mechanical message by a computer. I
>> dislike it strongly.
>
>> I would prefer the line to be more terse:
>
>> DETAIL:  90 transactions to finish.
>
>> Am I the only one who is annoyed by this phrase?
>
> Our style guidelines say that detail messages should be complete
> sentences, so I don't like your proposal too much.
>
> Maybe "N transactions remain to finish." ?

waiting for N transactions to complete

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Partitioned tables and relfilenode
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] error handling in RegisterBackgroundWorker