Re: redundant error messages - Mailing list pgsql-hackers

From Isaac Morland
Subject Re: redundant error messages
Date
Msg-id CAMsGm5dnrs69WMq3GK8f5BEWifVh1VVs3kpY2mMCv9PeuBu==g@mail.gmail.com
Whole thread Raw
In response to Re: redundant error messages  (Euler Taveira <euler.taveira@2ndquadrant.com>)
Responses Re: redundant error messages  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Thu, 5 Nov 2020 at 08:34, Euler Taveira <euler.taveira@2ndquadrant.com> wrote:

Is the database name important for this message? You should inform which
database you want to connect for all client tools except pg_dumpall. Hence, you
already know which database has the connection problem. IMO the pg_dumpall
message should inform the database name. My suggestion is:

In principle, the client knows the database name. In practice, if it's coming from PGDATABASE or via a service configuration, one may be confused about the database; having the error message be explicit will avoid many problems. I can easily imagine that "unable to connect to database" would be mystifying, whereas "unable to connect to database foo" would elicit the response, "wait, I'm trying to connect to what now?" leading much more quickly to a resolution.

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)
Next
From: Seino Yuki
Date:
Subject: Re: enable pg_stat_statements to track rows processed by REFRESH MATERIALIZED VIEW