[Patch]: Documentation of ALTER TABLE re column type changes onbinary-coercible fields - Mailing list pgsql-hackers

From Mike Lissner
Subject [Patch]: Documentation of ALTER TABLE re column type changes onbinary-coercible fields
Date
Msg-id CAMp9=ExS1z2R8ibe8oY9e7rRhHt1DBDK8O2UF7jcdgMPXEcnDQ@mail.gmail.com
Whole thread Raw
In response to Patching documentation of ALTER TABLE re column type changes onbinary-coercible fields  (Mike Lissner <mlissner@michaeljaylissner.com>)
Responses Re: [Patch]: Documentation of ALTER TABLE re column type changes onbinary-coercible fields  (Mark Dilger <mark.dilger@enterprisedb.com>)
RE: [Patch]: Documentation of ALTER TABLE re column type changes onbinary-coercible fields  ("k.jamison@fujitsu.com" <k.jamison@fujitsu.com>)
List pgsql-hackers
Hi all, I didn't get any replies to this. Is this the right way to send in a patch to the docs?

Thanks,


Mike

On Thu, Jan 23, 2020 at 11:01 PM Mike Lissner <mlissner@michaeljaylissner.com> wrote:
Hi, first patch here and first post to pgsql-hackers. Here goes.

Enclosed please find a patch to tweak the documentation of the ALTER TABLE page. I believe this patch is ready to be applied to master and backported all the way to 9.2.

On the ALTER TABLE page, it currently notes that if you change the type of a column, even to a binary coercible type:

> any indexes on the affected columns must still be rebuilt.

It appears this hasn't been true for about eight years, since 367bc426a.

Here's the discussion of the topic from earlier today and yesterday:


I haven't run tests, but I presume they'll be unaffected by a documentation change.

I've made an effort to follow the example of other people's patches I looked at, but I haven't contributed here before. Happy to take another stab at this if this doesn't hit the mark — though I hope it does. I love and appreciate Postgresql and hope that I can do my little part to make it better.

For the moment, I haven't added this to commitfest. I don't know what it is, but I suspect this is small enough somebody will just pick it up.

Mike
Attachment

pgsql-hackers by date:

Previous
From: Ibrar Ahmed
Date:
Subject: Re: VACUUM memory management
Next
From: Robert Haas
Date:
Subject: Re: Is custom MemoryContext prohibited?