Re: PATCH: decreasing memory needlessly consumed by array_agg - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: PATCH: decreasing memory needlessly consumed by array_agg
Date
Msg-id CAMkU=1ztioQhMa8YA8g9WVfD8hAVLqLyXxho65k1D3H1BDFr+g@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: decreasing memory needlessly consumed by array_agg  (Tomas Vondra <tv@fuzzy.cz>)
Responses Re: PATCH: decreasing memory needlessly consumed by array_agg  (Tomas Vondra <tv@fuzzy.cz>)
List pgsql-hackers
On Sat, Nov 29, 2014 at 8:57 AM, Tomas Vondra <tv@fuzzy.cz> wrote:
Hi,

Attached is v2 of the patch lowering array_agg memory requirements.
Hopefully it addresses the issues issues mentioned by TL in this thread
(not handling some of the callers appropriately etc.).

Hi Tomas, 

When configured --with-libxml I get compilation errors:

xml.c: In function 'xml_xpathobjtoxmlarray':
xml.c:3684: error: too few arguments to function 'accumArrayResult'
xml.c:3721: error: too few arguments to function 'accumArrayResult'
xml.c: In function 'xpath':
xml.c:3933: error: too few arguments to function 'initArrayResult'
xml.c:3936: error: too few arguments to function 'makeArrayResult'

And when configured --with-perl, I get:

plperl.c: In function 'array_to_datum_internal':
plperl.c:1196: error: too few arguments to function 'accumArrayResult'
plperl.c: In function 'plperl_array_to_datum':
plperl.c:1223: error: too few arguments to function 'initArrayResult'

Cheers,

Jeff

pgsql-hackers by date:

Previous
From: Rodrigo Gonzalez
Date:
Subject: Re: Commit fest 2014-12, let's begin!
Next
From: Jim Nasby
Date:
Subject: Re: Minor binary-search int overflow in timezone code