Re: Minor binary-search int overflow in timezone code - Mailing list pgsql-hackers

From Jim Nasby
Subject Re: Minor binary-search int overflow in timezone code
Date
Msg-id 548F5988.70002@BlueTreble.com
Whole thread Raw
In response to Re: Minor binary-search int overflow in timezone code  (Christoph Berg <cb@df7cb.de>)
Responses Re: Minor binary-search int overflow in timezone code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 12/15/14, 1:39 PM, Christoph Berg wrote:
> Re: Tom Lane 2014-12-15 <21813.1418655100@sss.pgh.pa.us>
>> This is totally silly.  The timecnt couldn't be anywhere near INT_MAX (in
>> fact, it is not allowed to exceed TZ_MAX_TIMES, which is currently just
>> 1200).  And there are bunches of other instances of similar code in PG;
>> shall we put equally wishy-washy comments on them all?
>
> Well, if it's not interesting, let's just forget it. Sorry.

At the risk of sticking my head in the lions mouth... this is the kind of response that deters people from contributing
anythingto the project, including reviewing patches. A simple "thanks, but we feel it's already clear enough that there
can'tbe anywhere close to INT_MAX timezones" would have sufficed.
 
-- 
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: PATCH: decreasing memory needlessly consumed by array_agg
Next
From: Alvaro Herrera
Date:
Subject: Re: Commit fest 2014-12, let's begin!