Rodrigo Gonzalez wrote:
> I have been reading this list for a long time and I have to say that I
> thought about reviewing patches for a long time....but I am really
> scared about few things....
>
> 1 - I have no knowledge at all about postgresql code so I can be doing
> things incorrectly (saying that something is fine or not fine, but
> making a mistake)
>
> 2 - English is not my main language...and I am not really good at
> English, reading is one thing, but writing is not as easy for me so
> maybe a review cannot be correctly understood
>
> Besides that, how long can take a review, simple one of course,
> considering that I starting vacations in 2 weeks.
>
> I really hope I can start helping here but I am afraid that maybe I can
> make things slower than today cause of my lack of source code..
If you never start, you will never get enough experience to do
meaningful reviews. Don't worry about making mistakes. If you don't
catch a problem, somebody else might. If you catch a problem and report
it to the patch author, you save somebody else the time to report that
problem. Eventually, with experience, your reviews will be good enough
that they will be valuable on their own right. Also, if you get enough
experience, you might eventually be able to write your own patches (or
you will discover you're not for the programming thing in the first
place.)
We have patches to review all year long; just have a look at the
http://commitfest.postgresql.org site whenever you think you will have
time. If you return from vacations in 4-5 weeks, I'm pretty sure we
will have patches to review at that time, too.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
