Re: add verbosity to pg_basebackup for sync - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: add verbosity to pg_basebackup for sync
Date
Msg-id CAMkU=1yG4Kyf3YJm55r5JecXt7wg+6oste38CkgmHbU6XDTnkQ@mail.gmail.com
Whole thread Raw
In response to Re: add verbosity to pg_basebackup for sync  (Michael Paquier <michael@paquier.xyz>)
Responses Re: add verbosity to pg_basebackup for sync
List pgsql-hackers
On Fri, Jul 27, 2018 at 7:10 PM, Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Jul 27, 2018 at 11:58:42AM -0400, Jeff Janes wrote:
> But it was really waiting for the syncs of the new -D dir to finish.  The
> attached patch adds a -v notice that it is starting to do the sync, with
> the wording taken from initdb's equivalent message.

This is a good idea.  Would we want that back-patched?  I am sure that
nobody is going to complain for an extra informational log.

Thanks for committing it.  It is probably safer not to backpatch, as someone might have scripts that look at the output of -v so it shouldn't change between minor releases.  I don't think looking at those would be a good idea, but they may have their reasons.  

Cheers,

Jeff

pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: [PATCH] Improve geometric types
Next
From: Michael Paquier
Date:
Subject: Re: Inconsistent error message in bt_page_items_bytea().