Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Improve geometric types - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: [PATCH] Improve geometric types
Date
Msg-id CAMkU=1wy+eemW=ZCJdgBk9s0gZawDz3UJxJPuohSt2GANiUhkQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Improve geometric types  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: [PATCH] Improve geometric types  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
Tree view


On Sat, Jul 28, 2018 at 9:54 PM, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:


I've committed the first two parts, after a review and testing.


I'm getting a compiler warning now:

geo_ops.c: In function 'line_closept_point':
geo_ops.c:2528:7: warning: variable 'retval' set but not used [-Wunused-but-set-variable]
  bool  retval;
 

gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)

Cheers,

Jeff
 
As these two parts were primarily refactoring (and quite extensive),
this seems like a good place to wait if the buildfarm is happy with it.
If yes, I'll continue applying the patches that do fix/change the
behavior in various ways.


regards

--
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: [PATCH] Improve geometric types
Next
From: Jeff Janes
Date:
Subject: Re: add verbosity to pg_basebackup for sync