Re: Fix bogus Asserts in calc_non_nestloop_required_outer - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Fix bogus Asserts in calc_non_nestloop_required_outer
Date
Msg-id CAMbWs48Q77XpfKX-+RY7u6Kt51MKkHeD4rZKv=-u8AP6AOhz_A@mail.gmail.com
Whole thread Raw
In response to Re: Fix bogus Asserts in calc_non_nestloop_required_outer  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: Fix bogus Asserts in calc_non_nestloop_required_outer
Re: Fix bogus Asserts in calc_non_nestloop_required_outer
List pgsql-hackers

On Thu, Sep 7, 2023 at 11:09 PM Aleksander Alekseev <aleksander@timescale.com> wrote:
Probably it's just because of my limited experience with the optimizer
but I don't find the proposed change particularly straightforward. I
would suggest adding a comment before the Assert's and/or a detailed
commit message would be helpful.

Comment is now added above the Asserts.  Thanks for taking an interest
in this.

Thanks
Richard
Attachment

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Inconsistent use of "volatile" when accessing shared memory?
Next
From: Jeff Davis
Date:
Subject: Re: Improve WALRead() to suck data directly from WAL buffers when possible