Re: Fix bogus Asserts in calc_non_nestloop_required_outer - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Fix bogus Asserts in calc_non_nestloop_required_outer
Date
Msg-id CAJ7c6TOJUzUNxiiPgCNhrqTjnWwkgAF3dgK0JwmCQEZpGMF8=A@mail.gmail.com
Whole thread Raw
In response to Fix bogus Asserts in calc_non_nestloop_required_outer  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Fix bogus Asserts in calc_non_nestloop_required_outer
List pgsql-hackers
Hi Richard,

> As stated in [1], all paths arriving here are parameterized by top
> parents, so we should check against top_parent_relids if it exists in
> the two Asserts.
>
> Attached is a patch fixing that.

Probably it's just because of my limited experience with the optimizer
but I don't find the proposed change particularly straightforward. I
would suggest adding a comment before the Assert's and/or a detailed
commit message would be helpful.

Other than that I can confirm that both branches in the Assert's are
executed and the tests pass in different test environments.

--
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Damir Belyalov
Date:
Subject: Re: Output affected rows in EXPLAIN
Next
From: Nazir Bilal Yavuz
Date:
Subject: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs