Re: Fix bogus Asserts in calc_non_nestloop_required_outer - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Fix bogus Asserts in calc_non_nestloop_required_outer
Date
Msg-id CA+TgmoZcjTkXF155tbG7sf5F9n-LUozNiQehY28123STstdYjQ@mail.gmail.com
Whole thread Raw
In response to Re: Fix bogus Asserts in calc_non_nestloop_required_outer  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Fix bogus Asserts in calc_non_nestloop_required_outer
List pgsql-hackers
On Fri, Nov 3, 2023 at 2:47 AM Richard Guo <guofenglinux@gmail.com> wrote:
> Comment is now added above the Asserts.  Thanks for taking an interest
> in this.

I'd like to suggest rewording this comment a little more. Here's my proposal:

Both of the paths passed to this function are still parameterized by
the topmost parent, because reparameterize_path_by_child() hasn't been
called yet. So, these sanity checks use the parent relids.

What do you think?

--
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: the s_lock_stuck on perform_spin_delay
Next
From: Robert Haas
Date:
Subject: Re: the s_lock_stuck on perform_spin_delay