Re: Typo in pg_db_role_setting.h - Mailing list pgsql-hackers

From Richard Guo
Subject Re: Typo in pg_db_role_setting.h
Date
Msg-id CAMbWs489+u6P_9qMjABsse0dNNBr36MA1SX5Ss7yZ7TD86mfKQ@mail.gmail.com
Whole thread Raw
In response to Re: Typo in pg_db_role_setting.h  (Japin Li <japinli@hotmail.com>)
Responses Re: Typo in pg_db_role_setting.h
Re: Typo in pg_db_role_setting.h
List pgsql-hackers

On Mon, Aug 1, 2022 at 10:42 PM Japin Li <japinli@hotmail.com> wrote:

On Mon, 01 Aug 2022 at 22:16, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> John Naylor <john.naylor@enterprisedb.com> writes:
>> You are correct, but I wonder if it'd be better to just drop the comment
>> entirely. I checked a couple other random headers with function
>> declarations and they didn't have such a comment, and it's kind of obvious
>> what they're for.
>
> Some places have these, some don't.  It's probably more useful where
> a header foo.h is declaring functions that aren't in the obviously
> corresponding foo.c file, or live in multiple files.  In this case
> I agree it's not adding much.
>

Attached patch to remove this comment.  Please take a look.

I'm not sure that we should remove such comments. And a rough search
shows that there are much more places with this kind of comments, such
as below:

nbtxlog transam readfuncs walreceiver buffile bufmgr fd latch pmsignal
procsignal sinvaladt logtape rangetypes

Thanks
Richard 

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
Next
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: Support logical replication of DDLs