Re: Typo in pg_db_role_setting.h - Mailing list pgsql-hackers

From Japin Li
Subject Re: Typo in pg_db_role_setting.h
Date
Msg-id MEYP282MB166996463A6A875B56AA4C38B69A9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Typo in pg_db_role_setting.h  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Typo in pg_db_role_setting.h
List pgsql-hackers
On Mon, 01 Aug 2022 at 22:16, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> John Naylor <john.naylor@enterprisedb.com> writes:
>> You are correct, but I wonder if it'd be better to just drop the comment
>> entirely. I checked a couple other random headers with function
>> declarations and they didn't have such a comment, and it's kind of obvious
>> what they're for.
>
> Some places have these, some don't.  It's probably more useful where
> a header foo.h is declaring functions that aren't in the obviously
> corresponding foo.c file, or live in multiple files.  In this case
> I agree it's not adding much.
>

Attached patch to remove this comment.  Please take a look.

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.


Attachment

pgsql-hackers by date:

Previous
From: Dong Wook Lee
Date:
Subject: Re: Add test of pg_prewarm extenion
Next
From: Justin Pryzby
Date:
Subject: Re: support for MERGE