Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin 4 - next gettext usage fixes - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: pgAdmin 4 - next gettext usage fixes
Date
Msg-id CAM9w-_kyiCB-FFtkXpvUNYKsz2iauZcm-vDs30dgW7rXDdDD-A@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin 4 - next gettext usage fixes  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: pgAdmin 4 - next gettext usage fixes  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Re: pgAdmin 4 - next gettext usage fixes  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Hackers/Libor,

The changes like below are incorrect. Try "Count rows" from a table's context menu.

-            info=gettext("Table rows counted: %s" % count),

+            info=gettext("Table rows counted: %s") % count,


Attached is the patch to fix all such changes in pgAdmin, to use format() instead.
Please review.

On Fri, Apr 10, 2020 at 2:57 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Libor

Thanks, patch applied. Please make sure to run the PEP8 checks before sending the patch.
I have fixed and committed the code.

On Wed, Apr 8, 2020 at 9:30 PM Libor M. <liborm85@gmail.com> wrote:
Hello,
I fixed next gettext usage:

- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in dialog
- improved translating sentences without "connecting" words (eg. see
web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs to
be translated in Czech language as 'zrušit' but in another sentence as
'zrušení')
- added gettext for text translations

Diff file is attached.

Best regards,

Libor M.

E-mail: liborm85@gmail.com
GitHub: https://github.com/liborm85


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: [pgAdmin4][Patch]: RM 5366 - PgAdmin hangs in 'loading' state aftertrying to preview the first 100 records
Next
From: Amol Vyavahare
Date:
Subject: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.