Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin 4 - next gettext usage fixes - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: pgAdmin 4 - next gettext usage fixes
Date
Msg-id CAG7mmoyvU=uWoRkeS9WKi=tHCZ83HqR_6Adv44qt5C7JkpweEA@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin 4 - next gettext usage fixes  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers/Libor,

The changes like below are incorrect. Try "Count rows" from a table's context menu.

-            info=gettext("Table rows counted: %s" % count),

+            info=gettext("Table rows counted: %s") % count,

I would also avoid using this syntax, when multiple variables need to be replaced.
e.g.
gettext("Test(#%s) -> %s") % test_no % test_result

Each language has different semantics, and the position of these variables may change based on them.
We should use the 'format' function with proper variables in such cases.
e.g.
gettext("Test(#{test_no}) ->{test_result}").format(test_no, test_result).

I've not reviewed the patch, but - please look at this aspect while reviewing the patch.

-- Thanks, Ashesh

Attached is the patch to fix all such changes in pgAdmin, to use format() instead.
Please review.

On Fri, Apr 10, 2020 at 2:57 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Libor

Thanks, patch applied. Please make sure to run the PEP8 checks before sending the patch.
I have fixed and committed the code.

On Wed, Apr 8, 2020 at 9:30 PM Libor M. <liborm85@gmail.com> wrote:
Hello,
I fixed next gettext usage:

- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in dialog
- improved translating sentences without "connecting" words (eg. see
web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs to
be translated in Czech language as 'zrušit' but in another sentence as
'zrušení')
- added gettext for text translations

Diff file is attached.

Best regards,

Libor M.

E-mail: liborm85@gmail.com
GitHub: https://github.com/liborm85


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Amol Vyavahare
Date:
Subject: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.
Next
From: Khushboo Vashi
Date:
Subject: [pgAdmin4][Patch] - RM 4957 - Constraint Trigger, Deferrable,Deferred option should be disbled if user select EDB-SPL function for triggerfor EPAS.