Re: pgAdmin 4 - next gettext usage fixes - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: pgAdmin 4 - next gettext usage fixes
Date
Msg-id CANxoLDcg=Jpkj5+16KNgAG171mz1bSF-+oFLRb_B4KAEO8Lb4w@mail.gmail.com
Whole thread Raw
In response to pgAdmin 4 - next gettext usage fixes  ("Libor M." <liborm85@gmail.com>)
Responses Re: pgAdmin 4 - next gettext usage fixes  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Hi Libor

Thanks, patch applied. Please make sure to run the PEP8 checks before sending the patch.
I have fixed and committed the code.

On Wed, Apr 8, 2020 at 9:30 PM Libor M. <liborm85@gmail.com> wrote:
Hello,
I fixed next gettext usage:

- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in dialog
- improved translating sentences without "connecting" words (eg. see
web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs to
be translated in Czech language as 'zrušit' but in another sentence as
'zrušení')
- added gettext for text translations

Diff file is attached.

Best regards,

Libor M.

E-mail: liborm85@gmail.com
GitHub: https://github.com/liborm85


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM5227] Cannot add user