Postgres Pro
Downloads
Home   >   mailing lists

Re: patch: option --if-exists for pg_dump - Mailing list pgsql-hackers

From Jeevan Chalke
Subject Re: patch: option --if-exists for pg_dump
Date
Msg-id CAM2+6=Uv3NpZgvnquN7ehbmeomduhRXRvJmijbeqN2i=8iPRgQ@mail.gmail.com
Whole thread Raw
In response to Re: patch: option --if-exists for pg_dump  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: patch: option --if-exists for pg_dump  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
Tree view
Hi Pavel,


Ok. Good.
Sorry I didn't update my sources. Done now. Thanks
 
 

Also, I didn't quite understand these lines of comments:

                        /*
                         * Descriptor string (te-desc) should not be same as object
                         * specifier for DROP STATEMENT. The DROP DEFAULT has not
                         * IF EXISTS clause - has not sense.
                         */

Will you please rephrase ?

I can try it - .

A content of te->desc is usually substring of DROP STATEMENT with one related exception - CONSTRAINT.
Independent to previous sentence - ALTER TABLE ALTER COLUMN DROP DEFAULT doesn't support IF EXISTS - and therefore it should not be injected.

is it ok?

Fine with me.

Thanks

--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Christian Kruse
Date:
Subject: Re: Suspicion of a compiler bug in clang: using ternary operator in ereport()
Next
From: Jeevan Chalke
Date:
Subject: Re: [PATCH] Filter error log statements by sqlstate