Re: patch: option --if-exists for pg_dump - Mailing list pgsql-hackers

Hi Pavel,

it should be fixed by http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b152c6cd0de1827ba58756e24e18110cf902182a commit

Ok. Good.

Sorry I didn't update my sources. Done now. Thanks
 

 

Also, I didn't quite understand these lines of comments:

                        /*
                         * Descriptor string (te-desc) should not be same as object
                         * specifier for DROP STATEMENT. The DROP DEFAULT has not
                         * IF EXISTS clause - has not sense.
                         */

Will you please rephrase ?

I can try it - .

A content of te->desc is usually substring of DROP STATEMENT with one related exception - CONSTRAINT.

Independent to previous sentence - ALTER TABLE ALTER COLUMN DROP DEFAULT doesn't support IF EXISTS - and therefore it should not be injected.

is it ok?

Fine with me.

Thanks

--

Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company