Postgres Pro
Downloads
Home   >   mailing lists

Move replication slot structures/enums/macros to a new header file for better usability by external tools/modules - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Move replication slot structures/enums/macros to a new header file for better usability by external tools/modules
Date
Msg-id CALj2ACW82S41r41K9gq+MA=NC1O5+C=RHjyjhw3PM9irseVJBA@mail.gmail.com
Whole thread Raw
Responses Re: Move replication slot structures/enums/macros to a new header file for better usability by external tools/modules  (Peter Smith <smithpb2250@gmail.com>)
Re: Move replication slot structures/enums/macros to a new header file for better usability by external tools/modules  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Tree view 
Hi,

While working on pg_replslotdata tool [1], it was observed that some
of the replication slot structures/enums/macros such as
ReplicationSlotPersistentData, ReplicationSlotPersistency,
ReplicationSlotOnDisk, ReplicationSlotOnDiskXXXX etc. are currently in
replication/slot.h and replication/slot.c. This makes the replication
slot on disk data structures unusable by the external tools/modules.
How about moving these structures to a new header file called
slot_common.h as attached in the patch here?

Thoughts?

PS: I'm planning to have the tool separately, as it was rejected to be in core.

[1] https://www.postgresql.org/message-id/CALj2ACW0rV5gWK8A3m6_X62qH%2BVfaq5hznC%3Di0R5Wojt5%2Byhyw%40mail.gmail.com

Regards,
Bharath Rupireddy.
Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
Next
From: Dilip Kumar
Date:
Subject: Re: Make relfile tombstone files conditional on WAL level