Postgres Pro
Downloads
Home   >   mailing lists

Re: Move replication slot structures/enums/macros to a new header file for better usability by external tools/modules - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Move replication slot structures/enums/macros to a new header file for better usability by external tools/modules
Date
Msg-id 20220210051733.tjygfn6cepqx7rth@alap3.anarazel.de
Whole thread Raw
In response to Move replication slot structures/enums/macros to a new header file for better usability by external tools/modules  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

On 2022-02-07 10:52:08 +0530, Bharath Rupireddy wrote:
> While working on pg_replslotdata tool [1], it was observed that some
> of the replication slot structures/enums/macros such as
> ReplicationSlotPersistentData, ReplicationSlotPersistency,
> ReplicationSlotOnDisk, ReplicationSlotOnDiskXXXX etc. are currently in
> replication/slot.h and replication/slot.c. This makes the replication
> slot on disk data structures unusable by the external tools/modules.

FWIW, I still don't see a point in pg_replslotdata. And I don't think these
datastructures should ever be accessed outside the server environment.

Greetings,

Andres Freund

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Use return value of XLogRecGetBlockTag instead of explicit block ref checks and also use XLogRecHasBlockRef/Image macros instead of explicit checks
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Make mesage at end-of-recovery less scary.