Re: Comment typo in tableam.h - Mailing list pgsql-hackers

From Ashwin Agrawal
Subject Re: Comment typo in tableam.h
Date
Msg-id CALfoeit_-5xq0srtL2KoSdUC0so5qBDPu1MRcdqwZkuxYCo5dA@mail.gmail.com
Whole thread Raw
In response to Re: Comment typo in tableam.h  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Comment typo in tableam.h
List pgsql-hackers

On Sat, Jul 6, 2019 at 12:05 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Tue, Jul 2, 2019 at 1:00 AM Ashwin Agrawal <aagrawal@pivotal.io> wrote:
> Please find attached v2 of patch 1 without objectionable comment change. v1 of patch 2 attaching here just for convenience, no modifications made to it.
>

0001*
  * See table_index_fetch_tuple's comment about what the difference between
- * these functions is. This function is the correct to use outside of
- * index entry->table tuple lookups.
+ * these functions is. This function is correct to use outside of index
+ * entry->table tuple lookups.

How about if we write the last line of comment as "It is correct to
use this function outside of index entry->table tuple lookups."?  I am
not an expert on this matter, but I find the way I am suggesting
easier to read.

I am fine with the way you have suggested.

pgsql-hackers by date:

Previous
From: Paul A Jungwirth
Date:
Subject: Re: range_agg
Next
From: Robert Haas
Date:
Subject: Re: tableam vs. TOAST