Re: Enhanced error message to include hint messages for redundant options error - Mailing list pgsql-hackers

From vignesh C
Subject Re: Enhanced error message to include hint messages for redundant options error
Date
Msg-id CALDaNm2WU+sDt5F-n+tzXnzfRmHkpHuViZ7_48wUqCWGHm_SGA@mail.gmail.com
Whole thread Raw
In response to Re: Enhanced error message to include hint messages for redundant options error  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Enhanced error message to include hint messages for redundant options error  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
On Sun, May 2, 2021 at 4:27 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2021-May-01, Bharath Rupireddy wrote:
>
> > IMO, it's not good to change the function API just for showing up
> > parse_position (which is there for cosmetic reasons I feel) in an error
> > which actually has the option name clearly mentioned in the error message.
>
> Why not?  We've done it before, I'm sure you can find examples in the
> git log.  The function API is not that critical -- these functions are
> mostly only called from ProcessUtility and friends.

I feel it is better to include it wherever possible.

Regards,
Vignesh



pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: Regex performance regression induced by match-all code
Next
From: Julien Rouhaud
Date:
Subject: Re: Enhanced error message to include hint messages for redundant options error