Re: Enhanced error message to include hint messages for redundant options error - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Enhanced error message to include hint messages for redundant options error
Date
Msg-id CAOBaU_ajsYtFLOWevn5LJ+-sv=xerh07nRSa2momJKqi6ao5Aw@mail.gmail.com
Whole thread Raw
In response to Re: Enhanced error message to include hint messages for redundant options error  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Le dim. 2 mai 2021 à 18:31, vignesh C <vignesh21@gmail.com> a écrit :
On Sun, May 2, 2021 at 4:27 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2021-May-01, Bharath Rupireddy wrote:
>
> > IMO, it's not good to change the function API just for showing up
> > parse_position (which is there for cosmetic reasons I feel) in an error
> > which actually has the option name clearly mentioned in the error message.
>
> Why not?  We've done it before, I'm sure you can find examples in the
> git log.  The function API is not that critical -- these functions are
> mostly only called from ProcessUtility and friends.

I feel it is better to include it wherever possible.

+1

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Enhanced error message to include hint messages for redundant options error
Next
From: vignesh C
Date:
Subject: Re: Enhanced error message to include hint messages for redundant options error