Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin bug - SQL creation for foreign keys - Mailing list pgadmin-hackers

From Dinesh Kumar
Subject Re: pgAdmin bug - SQL creation for foreign keys
Date
Msg-id CAKWsr7hgrYREBVP1UoG7oTHr10c_AJgG=DfyYShoJBRqx9TLrg@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin bug - SQL creation for foreign keys  (Dinesh Kumar <dinesh.kumar@enterprisedb.com>)
Responses Re: pgAdmin bug - SQL creation for foreign keys  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi Dave,

Further to my understanding, we don't any option available to deal untranslated strings in XRC files. Hence, i have reset the label text with the keywords. And also i have found this case with some other dialogue boxes, and adding fix for those also.

Please find the attached patch for the same, and let me know your inputs.

Thanks in advance.



Dinesh

-- 
Dinesh Kumar
Software Engineer

Ph: +918087463317
Skype ID: dinesh.kumar432
www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more


On Tue, Jul 16, 2013 at 1:05 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:
Hi Dave,

On Mon, Jul 15, 2013 at 6:55 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:
Hi Dave,

I am able to re-produce the reported issue and with the create new role dialogue box. Please find the attached patch for these reported cases.

This fix seems reasonable if we want the keywords to be translated in the UI, but I don't think we do, because they are keywords not natural language. Can we just prevent them being translated in the first place? If they're in the XRC file, that may require us to reset the labels to un-translated strings in code.


Thanks Dave. Let me send you new patch with this suggested approach.


Dinesh

-- 
Dinesh Kumar
Software Engineer
Skype ID: dinesh.kumar432
www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more

Attachment

pgadmin-hackers by date:

Previous
From: Javier Urbano Contreras
Date:
Subject: comparison schema/data
Next
From: Neel Patel
Date:
Subject: Re: Materialized View Patch File