Re: Materialized View Patch File - Mailing list pgadmin-hackers

From Neel Patel
Subject Re: Materialized View Patch File
Date
Msg-id CAMcbDBHnm0vSn7BkA1u9MwYe+frCEFkmk-+uxHF6MPYvwpToSQ@mail.gmail.com
Whole thread Raw
In response to Re: Materialized View Patch File  (Dave Page <dave.page@enterprisedb.com>)
Responses Re: Materialized View Patch File  (Dave Page <dave.page@enterprisedb.com>)
List pgadmin-hackers
Hi Dave,

Please find the updated patch with modification in query.

Thanks,
Neel Patel


On Wed, Jul 17, 2013 at 5:15 PM, Dave Page <dave.page@enterprisedb.com> wrote:
On Wed, Jul 17, 2013 at 12:23 PM, Neel Patel
<neel.patel@enterprisedb.com> wrote:
> Hi Dave,
>
> Just want to know.
>
> Now we are passing GetName() to qtDbString() and to form the complete query
> we need to use qtDbString() to compare the string.
>
> We have added below string.
>
> wxString sql = wxT("SELECT count(*) FROM pg_matviews WHERE matviewname = ")
> + qtDbString(this->GetName()) + wxT(" AND schemaname = ") +
> qtDbString(this->GetSchema()->GetName());
>
> Is it correct ?

I'd expect you to be using GetQuotedIdentifier() there. For a view and
schema, the identifier is the name anyway.


--
Dave Page
Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Attachment

pgadmin-hackers by date:

Previous
From: Dinesh Kumar
Date:
Subject: Re: pgAdmin bug - SQL creation for foreign keys
Next
From: Dave Page
Date:
Subject: Re: Materialized View Patch File