Re: Refactor to split nodeAgg.c? - Mailing list pgsql-hackers

From David Rowley
Subject Re: Refactor to split nodeAgg.c?
Date
Msg-id CAKJS1f-nZV0OzcX=NryzQijN6JE=zY5ZjXfNUyESj0ck9t9=kg@mail.gmail.com
Whole thread Raw
In response to Refactor to split nodeAgg.c?  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
On 30 June 2015 at 14:33, Jeff Davis <pgsql@j-davis.com> wrote:
I was going to rebase my HashAgg patch, and got some conflicts related
to the grouping sets patch. I could probably sort them out, but I think
that may be the tipping point where we want to break up nodeAgg.c into
nodeSortedAgg.c and nodeHashAgg.c, and probably a common file as well.

This would also (I hope) be convenient for Simon and David Rowley, who
have been hacking on aggregates in general.


That would be more inconvenient right now as I have a pending patch which makes quite a number of changes which are all over nodeAgg.c. https://commitfest.postgresql.org/5/271/

Regards

David Rowley

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
 

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Refactor to split nodeAgg.c?
Next
From: Heikki Linnakangas
Date:
Subject: Re: PANIC in GIN code