Refactor to split nodeAgg.c? - Mailing list pgsql-hackers

From Jeff Davis
Subject Refactor to split nodeAgg.c?
Date
Msg-id 1435631638.4369.62.camel@jeff-desktop
Whole thread Raw
Responses Re: Refactor to split nodeAgg.c?  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Refactor to split nodeAgg.c?  (Andres Freund <andres@anarazel.de>)
Re: Refactor to split nodeAgg.c?  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
I was going to rebase my HashAgg patch, and got some conflicts related
to the grouping sets patch. I could probably sort them out, but I think
that may be the tipping point where we want to break up nodeAgg.c into
nodeSortedAgg.c and nodeHashAgg.c, and probably a common file as well.

This would also (I hope) be convenient for Simon and David Rowley, who
have been hacking on aggregates in general.

Anyone see a reason I shouldn't give this a try?

Regards,Jeff Davis





pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: anole: assorted stability problems
Next
From: Robert Haas
Date:
Subject: Re: Reduce ProcArrayLock contention