Re: [patch] [doc] Clarify that signal functions have no feedback - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: [patch] [doc] Clarify that signal functions have no feedback
Date
Msg-id CAKFQuwZOqV2dUzwddPyk6GLccExODUrdEz_AaeHHgYQNo40bdw@mail.gmail.com
Whole thread Raw
In response to Re: [patch] [doc] Clarify that signal functions have no feedback  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: [patch] [doc] Clarify that signal functions have no feedback  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On Tue, Nov 17, 2020 at 6:13 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
On 02/11/2020 18:02, David G. Johnston wrote:
> diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
> index bf6004f321..43bc2cf086 100644
> --- a/doc/src/sgml/func.sgml
> +++ b/doc/src/sgml/func.sgml
> @@ -23892,7 +23892,8 @@ SELECT collation for ('foo' COLLATE "de_DE");

>     <para>
>      The functions shown in <xref
> -    linkend="functions-admin-signal-table"/> send control signals to
> +    linkend="functions-admin-signal-table"/> send uni-directional
> +    control signals to
>      other server processes.  Use of these functions is restricted to
>      superusers by default but access may be granted to others using
>      <command>GRANT</command>, with noted exceptions.

The "uni-directional" sounds a bit redundant, "send" implies that it's
uni-directional I think.

Agreed, the other two changes sufficiently address the original complaint.

You can use the <link
linkend="view-pg-file-settings">pg_file_settings</link> and <link
linkend="view-pg-hba-file-rules">pg_hba_file_rules</link> views to check
the configuration files for possible errors, before reloading.

I agree with adding "why" you want to check those links, and added a bit about why doing so before reloading works, but the phrasing using "You" seems out-of-place in this region of the documentation.

v3 attached

David J.
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_proc.dat "proargmodes is not a 1-D char array"
Next
From: Tom Lane
Date:
Subject: Re: pg_proc.dat "proargmodes is not a 1-D char array"