On Tue, Jan 22, 2019 at 12:15 PM Andres Freund <andres@anarazel.de> wrote:
Hi,
Thanks!
On 2019-01-22 11:51:57 +1100, Haribabu Kommi wrote: > Attached the patch for removal of scan_update_snapshot > and also the rebased patch of reduction in use of t_tableOid.
I'll soon look at the latter.
Thanks.
> > - consider removing table_gimmegimmeslot() > > - add substantial docs for every callback > > > > Will work on the above two.
I think it's easier if I do the first, because I can just do it while rebasing, reducing unnecessary conflicts.
OK. I will work on the doc changes.
> > While I saw an initial attempt at writing smgl docs for the table AM > > API, I'm not convinced that's the best approach. I think it might make > > more sense to have high-level docs in sgml, but then do all the > > per-callback docs in tableam.h. > > > > OK, I will update the sgml docs accordingly. > Index AM has per callback docs in the sgml, refactor them also?
I don't think it's a good idea to tackle the index docs at the same time - this patchset is already humongously large...