Re: Remove invalid indexes from pg_dump Was: Support for REINDEX CONCURRENTLY - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Remove invalid indexes from pg_dump Was: Support for REINDEX CONCURRENTLY
Date
Msg-id CAHGQGwEeb8yVs5xDnQf_kyVVUSWurY3_mS949=EUgLS2pciTQg@mail.gmail.com
Whole thread Raw
In response to Remove invalid indexes from pg_dump Was: Support for REINDEX CONCURRENTLY  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Tue, Mar 19, 2013 at 9:19 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> If failures happen with CREATE INDEX CONCURRENTLY, the system will be let
> with invalid indexes. I don't think that the user would like to see invalid
> indexes of
> an existing system being recreated as valid after a restore.
> So why not removing from a dump invalid indexes with something like the
> patch
> attached?

+1

The patch looks good to me.

> This should perhaps be applied in pg_dump for versions down to 8.2 where
> CREATE
> INDEX CONCURRENTLY has been implemented?

I think so.

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Next
From: Kevin Grittner
Date:
Subject: Re: Limiting setting of hint bits by read-only queries; vacuum_delay