Postgres Pro
Downloads
Home   >   mailing lists

Thread: Remove invalid indexes from pg_dump Was: Support for REINDEX CONCURRENTLY

Remove invalid indexes from pg_dump Was: Support for REINDEX CONCURRENTLY

From
Michael Paquier
Date:
Hi,

On Sun, Mar 17, 2013 at 9:24 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
> > Please find attached the patches wanted:
> > - 20130317_dump_only_valid_index.patch, a 1-line patch that makes pg_dump
> > not take a dump of invalid indexes. This patch can be backpatched to 9.0.
> The patch seems to change pg_dump so that it ignores an invalid index only
> when the remote server version >= 9.0. But why not when the remote server
> version < 9.0?
> I think that you should start new thread to get much attention about this patch
> if there is no enough feedback.

If failures happen with CREATE INDEX CONCURRENTLY, the system will be let
with invalid indexes. I don't think that the user would like to see invalid indexes of
an existing system being recreated as valid after a restore.
So why not removing from a dump invalid indexes with something like the patch
attached?
This should perhaps be applied in pg_dump for versions down to 8.2 where CREATE
INDEX CONCURRENTLY has been implemented?

I noticed some recent discussions about that:
http://www.postgresql.org/message-id/20121207141236.GB4699@alvh.no-ip.org
In this case the problem has been fixed in pg_upgrade directly.

Regards,
--
Michael
Attachment

Re: Remove invalid indexes from pg_dump Was: Support for REINDEX CONCURRENTLY

From
Fujii Masao
Date:
On Tue, Mar 19, 2013 at 9:19 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> If failures happen with CREATE INDEX CONCURRENTLY, the system will be let
> with invalid indexes. I don't think that the user would like to see invalid
> indexes of
> an existing system being recreated as valid after a restore.
> So why not removing from a dump invalid indexes with something like the
> patch
> attached?

+1

The patch looks good to me.

> This should perhaps be applied in pg_dump for versions down to 8.2 where
> CREATE
> INDEX CONCURRENTLY has been implemented?

I think so.

Regards,

-- 
Fujii Masao