Re: Improve search for missing parent downlinks in amcheck - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Improve search for missing parent downlinks in amcheck
Date
Msg-id CAH2-WznRmQHd0KegAXjossKJsytZE8HjT4B_6ZHPfxsXx8i6Pg@mail.gmail.com
Whole thread Raw
In response to Re: Improve search for missing parent downlinks in amcheck  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Improve search for missing parent downlinks in amcheck  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-hackers
On Tue, Apr 30, 2019 at 5:58 PM Peter Geoghegan <pg@bowt.ie> wrote:
> I will think about a simple fix, but after the upcoming point release.
> There is no hurry.

Attached draft patch uses RelationGetNumberOfBlocks() to size each of
the two Bloom filters that may be used by amcheck to perform
verification.

The basic heapallindexed Bloom filter is now sized based on the
conservative assumption that there must be *at least*
"RelationGetNumberOfBlocks()  * 50" elements to fingerprint (reltuples
will continue to be used to size the basic heapallindexed Bloom filter
in most cases, though). The patch also uses the same
RelationGetNumberOfBlocks() value to size the downlink Bloom filter.
This second change will fix your problem very non-invasively.

I intend to backpatch this to v11 in the next few days.

-- 
Peter Geoghegan

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Bad canonicalization for dateranges with 'infinity' bounds
Next
From: Michael Paquier
Date:
Subject: Re: Add parallelism and glibc dependent only options to reindexdb