On Thu, Jul 18, 2019 at 09:45:14AM +0900, Michael Paquier wrote:
> On Wed, Jul 17, 2019 at 07:46:10PM +0200, Julien Rouhaud wrote:
>> Is it ok to call pg_free(slots) and let caller have a pointer pointing
> to freed memory?
>
> The interface has a Setup call which initializes the whole thing, and
> Terminate is the logical end point, so having the free logic within
> the termination looks more consistent to me. We could now have actual
> Init() and Free() but I am not sure that this justifies the move as
> this complicates the scripts using it.
I have reconsidered this point, moved the pg_free() call out of the
termination logic, and committed the first patch after an extra lookup
and more polishing.
For the second patch, could you send a rebase with a fix for the
connection slot when processing the reindex commands?
--
Michael
