Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows
Date
Msg-id CAH2-WzmqZJwMYqmJuUwQnvwufH-7Ems-Qw=FcA-B9yHZoLCprQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows
List pgsql-hackers
On Thu, Sep 21, 2017 at 12:12 PM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
>> Attached patch shows what I'm getting at. This is untested, since I
>> don't use Windows. Proceed with caution.
>
> Your analysis makes sense, but the patch doesn't work, because "locale"
> is never set before reading it.

It was just for illustrative purposes. Seems fine to actually move the
WIN32 block down to just before the existing TRUST_STRXFRM test, since
the locale is going to be cached and then immediately reused where we
return immediately (Windows libc) anyway. This would also be a win for
clarity, IMV.

-- 
Peter Geoghegan


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Arrays of domains