Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows
Date
Msg-id 4935ec57-3e69-1a85-df4a-e47fc848b873@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On 9/21/17 15:21, Peter Geoghegan wrote:
> On Thu, Sep 21, 2017 at 12:12 PM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>>> Attached patch shows what I'm getting at. This is untested, since I
>>> don't use Windows. Proceed with caution.
>>
>> Your analysis makes sense, but the patch doesn't work, because "locale"
>> is never set before reading it.
> 
> It was just for illustrative purposes. Seems fine to actually move the
> WIN32 block down to just before the existing TRUST_STRXFRM test, since
> the locale is going to be cached and then immediately reused where we
> return immediately (Windows libc) anyway. This would also be a win for
> clarity, IMV.

I agree.  The attached patch should do it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Sokolov Yura
Date:
Subject: Re: [HACKERS] GUC for cleanup indexes threshold.
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] coverage analysis improvements