Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows
Date
Msg-id 24766dc5-5cf4-d0e4-ad6a-53fda20414c6@2ndquadrant.com
Whole thread Raw
In response to [HACKERS] ICU locales and text/char(n) SortSupport on Windows  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows
List pgsql-hackers
On 9/16/17 18:33, Peter Geoghegan wrote:
> In summary, we're currently attaching the use of SortSupport to the
> wrong thing. We're treating this UTF-16 business as something that
> implies a broad OS/platform restriction, when in fact it should be
> treated as implying a restriction for one particular collation
> provider only (a collation provider that happens to be built into
> Windows, but isn't really special to us).
> 
> Attached patch shows what I'm getting at. This is untested, since I
> don't use Windows. Proceed with caution.

Your analysis makes sense, but the patch doesn't work, because "locale"
is never set before reading it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Fix bool/int type confusion
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows