Re: [parallel query] random server crash while running tpc-h query on power2 - Mailing list pgsql-hackers

From Rushabh Lathia
Subject Re: [parallel query] random server crash while running tpc-h query on power2
Date
Msg-id CAGPqQf2_Vrn_GzXc_k88xrG=h1c9QwoZ_f4pJ2YUu9bJbJb9RQ@mail.gmail.com
Whole thread Raw
In response to Re: [parallel query] random server crash while running tpc-h query on power2  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [parallel query] random server crash while running tpc-h query on power2  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers


On Mon, Aug 15, 2016 at 6:02 PM, Robert Haas <robertmhaas@gmail.com> wrote:
On Sat, Aug 13, 2016 at 4:36 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> AFAICS, your patch seems to be the right fix for this issue, unless we
> need the instrumentation information during execution (other than for
> explain) for some purpose.

Hmm, I disagree.  It should be the job of
ExecParallelRetrieveInstrumentation to allocate its data in the
correct context, not the responsibility of nodeGather.c to work around
the fact that it doesn't.  The worker instrumentation should be
allocated in the same context as the regular instrumentation
information, which I assume is probably the per-query context.

I agree, this make sense.

Here is the patch to allocate worker instrumentation into same context
as the regular instrumentation which is per-query context.

PFA patch.


--
Rushabh Lathia
Attachment

pgsql-hackers by date:

Previous
From: amul sul
Date:
Subject: Re: Bug in to_timestamp().
Next
From: Venkata B Nagothi
Date:
Subject: Re: patch proposal